search

farisanadia / pe

0 stars 0 forks source link

adding date that does not exist with `addstudio` #9

Open farisanadia opened 1 year ago

farisanadia commented 1 year ago

When a studio is made with a date that does not exist (e.g., 2022-02-31), the date is auto-corrected (becomes 2022-02-28):

image.png

image.png

No error message is given. This can confuse users and result in them putting down the wrong date (e.g., they meant to put 21 feb but put 31 feb instead and it autocorrects to 28 feb without them knowing -> miss their studio)

Severity very high as this can affect use of the lesson function Similar behaviour is observed in addconsult and addmc

soc-pe-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Invalid DEADLINE date accepted and truncated for addtask

Command(s)
addtask t/Prepare tutorial slides d/2022-02-31

image.png

Does not throw an invalid date error, instead adds a task on 28th February.

Expected: Invalid date error

[original: nus-cs2103-AY2223S1/pe-interim#4905] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Invalid dates are not accepted but rounded down to the nearest valid date. This only happens when the day is 31 or less (i.e the app does not accept if 2022-08-32 is entered).

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: This behavior was not indicated in the user guide and is likely to not be noticed by the user due to the large amounts of information on the screen at any point in time. As stated in my original test review, if someone meant to put down 21-02-2022 but adds 31-02-2022, the date will be rounded down to 28-02-2022, which visually looks similar to 21. Not noticing the mistake, they might miss their lesson.

image.png According to the textbook, a severity.low is a flaw that is unlikely to affect normal operations of the product. It is not unlikely to put the wrong date down, especially for tutors with many students and alot of information to arrange. Furthermore, there is no message detailing the rounded down date, nor is there any information in the user guide.