search

farisfaikar / Number-Game

Number Game is a game where players solve a 4-digit secret number combination using clever deductions!
MIT License
17 stars 9 forks source link

Fixed Sound Issue #49

Closed spaghettiosareyummy closed 2 years ago

spaghettiosareyummy commented 2 years ago

This PR is to fix issue #31 .

This issue was caused by pygame being unable to read the .ogg files that contained the sounds. To combat this, I converted the files into the WAV format.

I've tested on Mac, Linux, and Windows, all seem to work perfectly!

spaghettiosareyummy commented 2 years ago

I've tested it out and it works! But now there's the issue of the sound files getting too big. WAV format tends to be very big, I've checked the sound file and it alone uses up to 77 MB now. Can you convert it to another format, such as mp3 (I think I tried mp3 before and it didn't work, but maybe I was doing it wrong) or other formats that are smaller in size?

I did try mp3 before attempting WAV and it didn't work properly. I will try to find another file format that is smaller.

spaghettiosareyummy commented 2 years ago

Pygame currently only supports mp3, ogg, and WAV. WAV is the only one that works out of the three.

farisfaikar commented 2 years ago

Is it possible to compress the WAV files further?

spaghettiosareyummy commented 2 years ago

Apologies for the delay in my responses, I have managed to compress the WAV files to be much smaller than they were originally. To my knowledge, this hasn't sacrificed sound quality at all.