search

farizrahman4u / recurrentshop

Framework for building complex recurrent neural networks with Keras
MIT License
765 stars 218 forks source link

Cumulative Update for Keras 2.2.0 and some fixes and Explanations in the README.md #103

Closed Pyrestone closed 6 years ago

Pyrestone commented 6 years ago

This Pull request includes fixes for the issues addressed in #102 #101, #96, #94 and #76 along with the bug in farizrahman4u/seq2seq#177 and farizrahman4u/seq2seq#250 (both caused by calls to the deprecated keras.engine.topology class.)

Pyrestone commented 6 years ago

While waiting for a response from @farizrahman4u, you can use the installation instructions from pyrestone/recurrentshop to install the library for keras 2.2.0

Pyrestone commented 6 years ago

I added another fix for the Tensorflow teacher-forcing bug, fixing #81 and making the tf-teacher-force branch obsolete.

farizrahman4u commented 6 years ago

Thanks for the effort. Couple of small changes required.

Pyrestone commented 6 years ago

@farizrahman4u Done.

farizrahman4u commented 6 years ago

Lgtm, Thanks!

ty5491003 commented 6 years ago

Thank you for your work!

I just tested it, worked! thanks again!