LSTMDecoderCell needs a get_config(self)

[inzaghi250]

I found that the latest commit removes the old get_config(self).

However in init:

def __init__(self, hidden_dim=None, **kwargs):
    if hidden_dim:
        self.hidden_dim = hidden_dim
        kwargs['units'] = hidden_dim
    else:
        self.hidden_dim = kwargs['units']
    super(LSTMDecoderCell, self).__init__(**kwargs)

'units' is involved in the potential config. It may cause unfound key when we serialize and then deserialize LSTMDecoderCell.

[abhaikollara]

@inzaghi250 The kwargs['units'] = hidden_dim line was a bug, it has been removed in the latest commit

[inzaghi250]

@abhaikollara The remaining line self.hidden_dim = kwargs['units'] still causes KeyError. When LSTMDecoderCell is serialized, the get_config() of ExtendedRNNCell is used because LSTMDecoderCell does not have one. This makes the 'units' attribute unincluded. When deserialized, init is called with default hidden_dim (None), which excecutes the aforementioned line.

[abhaikollara]

@inzaghi250 Update seq2seq, your issue should be solved

[inzaghi250]

@abhaikollara I see the fix: 12 if hidden_dim: 13 self.hidden_dim = hidden_dim 14 else: 15 self.hidden_dim = self.output_dim 16 super(LSTMDecoderCell, self).init(**kwargs) However, self.output_dim still get uninitialized before use, because it is initialized at Line 16?

[inzaghi250]

@farizrahman4u Please help check the above issue. It causes simple save & load of models to fail.

[farizrahman4u]

@abhaikollara