search

farkam135 / GoIV

https://www.reddit.com/r/goiv
Other
372 stars 138 forks source link

MixedUnicodeToken: Returnvalue now matches token description in GoIV #1017

Closed BigCabbage closed 5 years ago

BigCabbage commented 5 years ago

This PR addresses https://github.com/farkam135/GoIV/issues/1016, which has also been discussed on Reddit: https://www.reddit.com/r/GoIV/comments/a0u2yo/problem_with_uivmixed07_display_of_calculated/

It fixes the returnvalue to be in line with the description in the app GoIV, which states that it returns the lowest value for each stat. Instead, it currently returns the lowest IV combination.

BigCabbage commented 5 years ago

I checked this build failure from Travis CI build, it has absolutely nothing to do with my patch.

nahojjjen commented 5 years ago

Seems to be working

BigCabbage commented 5 years ago

Thanks a lot, removed the no-longer needed branch. Will see if I contribute more.