farkam135 / GoIV

https://www.reddit.com/r/goiv
Other
372 stars 138 forks source link

Option to keep IV button floating at all times #263

Open rpgrca opened 8 years ago

rpgrca commented 8 years ago

In Ingress we have Integrated timer for Ingress which keeps the floating timer at all times, and only makes it disappear when the application is switched.

Currently the modes are screenshot (where you need to take a screenshot to get it processed) or scanning your screen continuously. The problem with screenshot mode is that it's rather slow, and that screenshots don't save in the filename your current level (so if you keep them for you to later process them for whatever reason, you'd have to remember the level you were back then). You might even be able to save the screenshot with the filename containing the scanned data, or save it in the EXIF.

Having the floating button doesn't actually disturb gameplay (especially if you can move it around as the timers), would take the best of both worlds, and maybe even get it back to the Play Store (if what people say that the application was removed because of recording the screen continuously was what made it being removed).

As long as the OCR doesn't crash if the user presses the button at the wrong time, it should be pretty safe.

voltaek commented 8 years ago

To add to @rpgrca's suggestion, I think a floating, movable button (a la Facebook Messenger) that when tapped temporarily enables screen capture for only long enough to perform the screen scan would be a great way to both save battery life and make any logic for detecting when to display the IV button no longer needed, while still only requiring one button tap from users.

oskomonzon commented 8 years ago

I'd preffer @voltaek's approach on this one (and adding this feature was mentioned/discussed a couple of times). I think we would need new permissions to be able to automatically show and hide the floating button, and I'd rather don't mess with that. Plus, having it in the notification drawer is less intrusive for the user. We must not forget a simple fact: Most of the gameplay occurs outside the Pokemon details tab and the button would serve no purpose outside of it, leading to clutter for no gain in most case scenarios.

voltaek commented 8 years ago

Personally, I'd prefer to use the floating button method rather than #268, as it means the screen scanning is only enabled for the moment the analyzing is actually occuring. On my Nexus 6, having the screen scanning running makes PoGo run noticeably choppier, so I think the shorter the amount of time it's on for, the better. And if the user doesn't have to actually toggle the scanning itself, but rather "starting" GoIV is now just showing the button instead, and they can long-press it to drag to a "hide button" area of the screen, then you have a smoother running game and you have the minimal amount of battery usage possible while still using OCR.

There is a third option, which is to use the notification action to actually show/hide the floating button (since there would be no starting/stopping of screen reading), which would kind of be the best of both worlds.

voltaek commented 8 years ago

@Blaisorblade I see you've added this to the 3.3.0 milestone, but have also added the notification buttons issue to it, when based on my thoughts on how each implementation should act, only one of them should be necessary. Please see my comments in this issue and the notification button one.

Secondly, should I rename this issue since it's not just about keeping the button up at all times, but more importantly about having the scanning service run only for as long as needed to perform a quick scan when the button is clicked and then immediately stopping the service again?

Blaisorblade commented 8 years ago

@voltaek Ah, just found #268. Thanks for pointing out they're alternative; the milestone planning is approximate, so the current plan is "let's pick what to do after 3.2".

And right now, #268 appears simpler to implement. A floating button sounds cooler but I'm not sure who can do this (or find the time to learn how to do it) and of all my floating buttons, exactly zero work reliably. (Facebook might have worked correctly before I decided to disable it).

Blaisorblade commented 8 years ago

Forgot to say: I'm happy if somebody volunteers for this.