farkam135 / GoIV

https://www.reddit.com/r/goiv
Other
372 stars 141 forks source link

Add move and Pokemon types to clipboard #683

Open canavan opened 7 years ago

canavan commented 7 years ago

I'd like to see the move types added as an optional component to the clipboard string. Additionally, the some may find the Pokemon type useful as well, so that sorting by name becomes equivalent to sorting by type. To conserve space, Unicode symbols would be nice, such as those suggested by various posters in this reddit thread:

https://www.reddit.com/r/TheSilphRoad/comments/69f65u/i_want_to_use_unicodesymbols_in_nicknames_but

Apparently not all symbols show on all phones, so an additional editor for the symbols, or at least a selection for a symbol set may be required. If possible, the same font that Pokemon Go uses should be used here.

On top of all that, I personally like to mark the mon that have hatched from eggs, currently by replaing the 3 letter Name with "egg", although a Unicode symbol may be more efficient. Since this information also restricts the IV possibilities, it would be a useful input, and another welcome addition to the clipboard string.

AndrewMcQuerry commented 7 years ago

My experience with the Moves themselves, is that they are often below the bottom of the screen for various phone types and resolutions. Thus, I'm not sure what it would take to add detection code that is able to find it when it's present, but not get confused when it's simply below the viewable screen.

Scanning and using the Pokemon's Type was recently added to GoIV. So far it's only being used to accurately detect which Eeveelution is being viewed. But, I think it's quite reasonable for this info to be available as a clipboard token. Adding in Unicode mapping for the types would present some additional challenges, as you have mentioned (phones, support, font, etc). I don't know enough about what font or character set Pokemon Go uses to be able to "predict" all unicode characters that it would support.

About the eggs... GoIV has no way to "know" that a pokemon came from an egg. The only option here that I could see is adding yet another button/checkbox in the edit section that would allow the user to say, "This Pokemon came from an egg". A different feature has previously been discussed that would utilize this to further filter OUT any IV combinations less than 10-10-10.

canavan commented 7 years ago

the Moves themselves, is that they are often below the bottom of the screen for various phone types and resolutions

The visibility of move types apparently also depends on the size of the Pokemon - on my phone, they are not visible by default for small ones like Pidgey, Spinarak or Togepi, but always visible for Togetic, Noctowl, Ursaring, Snorlax or Dragonite.

be able to "predict" all unicode characters that it would support.

I had assumed that it was "known" which font was used, because I assumed it would be part of the APK. The fact that different characters are usable in Android and IOS is an indicator that this is not the case. A workaround would be a reasonable preset and using Noto for custom selections. If it's not displayed in the game, the user would have to pick something else.

The only option here that I could see is adding yet another button/checkbox

That was essentially what I asked for, but obviously I didnt' make this clear enough.

suroh1994 commented 6 years ago

Is this issue still being worked on?

The visibility of move types apparently also depends on the size of the Pokemon - on my phone, they are not visible by default for small ones like Pidgey, Spinarak or Togepi, but always visible for Togetic, Noctowl, Ursaring, Snorlax or Dragonite. What you witnessed is the fact, that pokemon which are not fully evolved have the evolve button below the powerup button and therefore their moves are pushed down below the screen limit. This could be easily detectable, since we have the evolve button on screen. And in case it is not fully evolve I don't think someone would care too much about the moves. At least i don't.

Considering the visibility I can only say: for fully evolved Pokemons the OnePlus 3, Samsung Note 3, iPhone 5s and iPad (2.Gen) all show the moves. I know the Apple devices can't run goiv, I just wanted to see whether they would show the moves. Isn't the visibility bound to the screen resolution/aspect ratio? Is there a way for the app to detect the resolution/the aspect ratio so the move detection feature could be disabled if the moves are straight up not visible?

nahojjjen commented 6 years ago

We're talking about adding moveset scanning in the discord chat, we're talking about having moveset evaluation and clipboard-tokens for moves & types, but it'd be a big change code and UI wise...