search

farkam135 / GoIV

https://www.reddit.com/r/goiv
Other
372 stars 138 forks source link

bug: with appraisal refining 'really strong' does not.... #684

Open MartinParis opened 7 years ago

MartinParis commented 7 years ago

bug: with appraisal refining 'really strong' does not get recognized when the name of the pokemon drives the 'strong' string to the second line in the pogo appraisal pop up/message box. screenshot_20170512-113840 screenshot_20170512-113904

AndrewMcQuerry commented 7 years ago

Yes, this is an unfortunate side effect of the way that the OCR is pulling the text string and then how we are comparing one to the other. I would venture that the proper solution here would be to see about manipulating the OCR'd string to properly "remove" any new-lines (can't remember how they are represented in the text string), so that the phrases we are looking for should match regardless of same line or wrapped-line.

For now, keep your Pokemon names short. ;) (kidding)

MartinParis commented 7 years ago

Hi, minor issue already, but with latest update even more minor 😀, IV is also downgraded in its effect.

Op 1 jul. 2017 07:37 schreef "Andrew Mc" notifications@github.com:

Yes, this is an unfortunate side effect of the way that the OCR is pulling the text string and then how we are comparing one to the other. I would venture that the proper solution here would be to see about manipulating the OCR'd string to properly "remove" any new-lines (can't remember how they are represented in the text string), so that the phrases we are looking for should match regardless of same line or wrapped-line.

For now, keep your Pokemon names short. ;) (kidding)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/farkam135/GoIV/issues/684#issuecomment-312412240, or mute the thread https://github.com/notifications/unsubscribe-auth/AHYtPVj67aSfvnMqjiY2CzW32Ok5NcfYks5sJdr2gaJpZM4NZdRi .