search

farling42 / fvtt-disguise-unreachable-links

Foundry VTT module that hides links from players if they aren't reachable.
MIT License
0 stars 0 forks source link

Still broken links as Player when using wiki import? #1

Closed Sonny-Crockett closed 2 years ago

Sonny-Crockett commented 2 years ago

I am using your module and the https://github.com/rlach/wiki-import

When importing links and previewing from a player it seems they have the same broken link view that I do. Any ideas?

example

farling42 commented 2 years ago

Can you show what the links look like in edit mode please.

Sonny-Crockett commented 2 years ago

` Rupings were a notable @JournalEntry[reptavian]{reptavian} @JournalEntry[species]{species} native to the @JournalEntry[planet]{planet} @JournalEntry[Onderon]{Onderon}. They had vocal chords that produced a rasping roar, @JournalEntry[Limb]{finger}-like wingtips, and a thumb claw that allowed them to grasp and climb with their wings. Loyal and brave creatures, ruping were used as mounts by the @JournalEntry[Onderon rebels]{Onderon rebels} led by @Compendium[world.swaadversaries.MpmUkqc0kFFtHiRb]{Saw Gerrera} during the @JournalEntry[Onderon Civil War]{Onderon Civil War}, who equipped them with @JournalEntry[saddle]{saddles} and reins.

Behind the scenes The ruping is named after the @JournalEntry[Star Wars: The Clone Wars]{Star Wars: The Clone Wars} concept artist @JournalEntry[Tara Rueping]{Tara Rueping}, who designed the creature.

Appearances

Sources @JournalEntry[Star Wars: Absolutely Everything You Need to Know]{Star Wars: Absolutely Everything You Need to Know} @JournalEntry[Star Wars: The Visual Encyclopedia]{Star Wars: The Visual Encyclopedia} @JournalEntry[Star Wars: Absolutely Everything You Need to Know, Updated and Expanded]{Star Wars: Absolutely Everything You Need to Know, Updated and Expanded} @JournalEntry[Star Wars: The Visual Encyclopedia]{Star Wars: The Visual Encyclopedia} @JournalEntry[Star Wars: Absolutely Everything You Need to Know, Updated and Expanded]{Star Wars: Absolutely Everything You Need to Know, Updated and Expanded} Notes and references `

farling42 commented 2 years ago

Ok, so all the links are being stored by name, rather than by id. I will see what I can do about that.

Sonny-Crockett commented 2 years ago

Great, any help is appreciated!

farling42 commented 2 years ago

If you disable the "disguise unreachable links" module, do you see the same broken links?

Sonny-Crockett commented 2 years ago

Yes but my issue was happening before your module, so no worries there.

image

farling42 commented 2 years ago

So, is your request that broken links appear as normal text for players, rather than as broken links?

Sonny-Crockett commented 2 years ago

Yes, that is my hope. Basically, since my system does not have any real content I can buy digitally, I have to import from public and free sources and its a lot of work to clean it up from the broken links. I found your module and figure it was perfect for my issue. Thank you for even responding to me :)

Even bigger ask would be a toggle for GMs, so they can see it normally but flip a switch to see what links they need to fix. But thats 1000% not needed, just an idea.

farling42 commented 2 years ago

Well, I must admit that you are the first person to report an issue with the module.

And, in fact, the issue was that when I separated this code out from the Realm Works Importer module, I didn't actually do it properly. So this module never actually did anything.

I've just created 1.1, so if you do a manual update then you might see that appear, and it should work properly.

Sonny-Crockett commented 2 years ago

image

Incredible! Thank you so much.

farling42 commented 2 years ago

Your welcome :)