search

farling42 / fvtt-extra-embed

Extra Embed Options
MIT License
0 stars 0 forks source link

You're not shipping your language file #3

Open esheyw opened 1 week ago

esheyw commented 1 week ago

Your github workflow is set up to zip a language/ folder, but this repo has languages/ instead, so the produced release does not contain your en.json:

edit: I just actually looked at en.json for the first time. It's understandable why this would go unnoticed, lol.

farling42 commented 1 week ago

Thanks for pointing this out.

It is an error in the core template (https://github.com/League-of-Foundry-Developers/FoundryVTT-Module-Template/blob/master/.github/workflows/main.yml) which I keep forgetting to modify in my local projects.

The fixed workflow will be in the next release, since it doesn't affect the module's behaviour :-)