search

farling42 / fvtt-pdf-pager

PDF Pager for Foundry
MIT License
6 stars 4 forks source link

Annotating not shared or saved, prevents game world being shut down/reloaded while pdf is open #107

Closed 4m2c4bl3 closed 1 month ago

4m2c4bl3 commented 1 month ago

I am sure to de-select the annotation tool, but none of the data saves. When annotating from a browser window and going to navigate away, it gives me 'unsaved changes will be lost' warnings. When annotating from the main foundry vtt client, trying to reload app or return to setup or even exit does nothing, until I close the pdf.

image

farling42 commented 1 month ago

Which version of Foundry? Are any errors reported in the browser Console (can be opened with F12)?

4m2c4bl3 commented 1 month ago

V12, build 328, and nope.

https://github.com/user-attachments/assets/2faf0a4d-8949-4df2-b4b3-6c55eba075fd

farling42 commented 1 month ago

In the console, could you enter the following which should provide some debug in the console, so that I can see what is happening (or not) with your installation - and then repeat the above steps.

CONFIG.debug.pdfpager=true

And set the console output to show All levels

farling42 commented 1 month ago

Ah, also which game system are you using?

farling42 commented 1 month ago

I've just noticed that it is possible to edit even if the user has only Observer rather than Owner permission on the document.

4m2c4bl3 commented 1 month ago

I'm using this system: https://github.com/League-of-Fabulous-Developers/FoundryVTT-Fabula-Ultima

with debugging on, i'm not seeing anything new image (also all levels is on)

image

farling42 commented 1 month ago

I don't know if this is the cause, but I've just created version 1.1.5 which will prevent non-OWNERs from being able to add annotations to PDF pages.

4m2c4bl3 commented 1 month ago

thanks, i'll give it a try.

4m2c4bl3 commented 1 month ago

observer role is still able to see/use editing tools in 1.1.5, and the behavior remains the same for the owner. i'm going to try and create a new game world with no other addons to see if there's something else conflicting.

i made a new world with only the system and PDF-pager, and i finally am seeing an error message.

image this didn't come back after i cleaned the console, but i caught it once. is there some required information that has to be defined for each system? also seeing messages now about "already loaded annotations for page 1 - ignoring"

https://github.com/user-attachments/assets/2d481eeb-4c72-4d29-89e5-648a595667f3

farling42 commented 1 month ago

That error about a missing file is unavoidable. It just means that the module doesn't ship with any predefined mappings for your game system. I am still trying to find how to stop it from being reported.

farling42 commented 1 month ago

Could you give me a screen shot of this module's settings in your foundry please.

farling42 commented 1 month ago

Also, does it occur with all other modules disabled (other than pdf-pager and libWrapper)?

I've now got Fabula Ultima game installed on Foundry 12, but I'm running Chrome rather than the app, and everything seems to be working.

farling42 commented 1 month ago

I've just noticed that annotations aren't saved if "Support Form-Fillable PDFs" is not enabled.

farling42 commented 1 month ago

Version 1.1.6 will save annotations when "Support Form-Fillable PDFs" is not enabled (as well as when it is enabled).

4m2c4bl3 commented 1 month ago

I've just noticed that annotations aren't saved if "Support Form-Fillable PDFs" is not enabled.

That was it!! Thanks so much :)