farling42 / fvtt-pdf-pager

PDF Pager for Foundry
MIT License
6 stars 4 forks source link

Old @PDF links used a key instead of name broken. #36

Closed SalieriC closed 1 year ago

SalieriC commented 1 year ago

Overall this module is a live saver. Unfortunately, my old @PDF links are broken. They used an abbreviation that you were able to set in PDFoundry, instead of the full name of the PDFs journal document. Here is an example:

@PDF[HRE1|page=4]{Hellfrost Rassilon Expansion 1}
@PDF[Hellfrost Rassilon Expansion 1|page=4]{Hellfrost Rassilon Expansion 1}

The first link is how it was placed earlier by PDFoundry, the second one in as it is expected now by PDF Pager. The abbreviation is ofc something that isn't used in PDF Pager but the journals still contain the flags from PDFoundry: image Thus the data is still there. I don't know whether or not the link updater takes this into account but if not I suggest that it should. It would also be nice if PDF Pager could take the abbreviation into account.

farling42 commented 1 year ago

Ah, I wasn't sure if anybody was using that particular syntax. I will incorporate it into the next release ; to use either full name or the "PDF Code"

farling42 commented 1 year ago

Version 0.31.0 adds support for: @PDF[pdfcode]{label} @PDF[pdfcode|page=xx]{label}

farling42 commented 1 year ago

Note that PDF Pager already supported the use of "PDF Code", but this was previously only used in PDF Pager with the ui.pdfpager.openPDFByCode function