farling42 / fvtt-pdf-pager

PDF Pager for Foundry
MIT License
6 stars 4 forks source link

German translation for pdf-pager 0.34 including changes to translate title buttons #40

Closed CePeU closed 1 year ago

CePeU commented 1 year ago

The changes are for de.json and pdf-actorshet.mjs I translated the missing translation strings and also tried to enhance the data structure for translation of the title buttons in de.json. To translate the title buttons pdf-actorsheet.mjs needs to be adjusted. Also probably en.json would need an adjustment.

As I am still not very profficient with JS I hope the code change will be ok. Probably the translations of the translationstrings for the buttons could be put somewhere else also ;). Feel free to adjust my "coding".

CePeU commented 1 year ago

Hmm I am reall struggling to get a grasp on how Github works. I used Windows and Visual studio Code. So possibly if you used linux there might be different code pages/line endings. For simplicity (for me I will post it into this comment). It is just two lines anyway:

  _getHeaderButtons() {
    let buttons = super._getHeaderButtons();

    // translation strings for title buttons
    const CustomPDF = game.i18n.localize(`${PDFCONFIG.MODULE_NAME}.TitleButtonName.CustomPDF`);
    const InspectData = game.i18n.localize(`${PDFCONFIG.MODULE_NAME}.TitleButtonName.InspectData`);
   // end translation strings for title buttons

    buttons.unshift({

The en.json needs to also be expanded:

"TitleButtonName": {
            "CustomPDF": "Custom PDF",
            "InspectData": "Inspect Data"
        }