search

farling42 / fvtt-pdf-pager

PDF Pager for Foundry
MIT License
6 stars 4 forks source link

[Bug] PDF settings don’t save #78

Closed mrkwnzl closed 4 months ago

mrkwnzl commented 7 months ago

When I edit the journal page of the PDF, the zoom level isn’t transferred over from the edit sheet to the journal.

Steps to reproduce:

  1. Open a PDF.
  2. Click “Edit”
  3. Change the Zoom level to any other value. It changes in the edit sheet, but not in the journal.

I’m not getting an error message. I tried setting Default Zoom to “none,” and disabling Ignore Zoom in Bookmarks, to no avail.

Foundry Electron App, v11.315 PDF Pager v0.49.0 Cypher System v2.12.0 (although I believe that to be irrelevant, but just in case)

mrkwnzl commented 7 months ago

I think this can be generalized. None of the settings for the PDF I set in the PDF edit sheet appear in the journal. Is that by design?

farling42 commented 7 months ago

I think this is a consequence of any settings you make within the PDF viewer (pdfjs) itself (such as zoom, or choice of page layout) are only stored within that instance of the PDF viewer, they are not read by the PDF Pager module.

farling42 commented 7 months ago

Although I can investigate to see if it is possible to get (and set) the current state of the pdfjs library and store it as part of the PDF Pager's settings for the PDF.

mrkwnzl commented 7 months ago

If it’s not possible, it might be a good idea to have an option to show the control bar on the page.

farling42 commented 7 months ago

See the "Hide PDF Browser Toolbar" module option, which is enabled by default.

mrkwnzl commented 7 months ago

See the "Hide PDF Browser Toolbar" module option, which is enabled by default.

🙈 User error. Sorry, I missed that.

farling42 commented 4 months ago

Closing as won't be adding any additional functionality to save settings which are part of the core pdfjs library.