search

farling42 / fvtt-pdf-pager

PDF Pager for Foundry
MIT License
6 stars 4 forks source link

Various performance changes #99

Closed bchiu3 closed 1 month ago

bchiu3 commented 1 month ago

Modified myFlattenObject call to pass in string instead of allocating space for a map on every call stack.

Small change specifically in myFlattenObject call for pathfinder 2e only.

Allowed arrays to be added to search due to other systems using an actor.system style.

Removing stack.delete due to problems stated with pf2e here: https://github.com/farling42/fvtt-pdf-pager/issues/98#issuecomment-2168679500

Swapped static datalist with a dynamic one due to memory issues. This stemmed from too many possible fillable fields along with too many possible values, increasing DOM size and therefore increasing memory usage. DND5e runs fine statically, but other systems like PF2e has too many key-value pairs within the actor object to viably work.

Feel free to enact any changes.

farling42 commented 1 month ago

Version 0.53.3 includes fixes in a slightly different manner to what was proposed here.