Layer switcher not necessarily updated when layers are removed from the map

Here's some behavior code to replicate against - this is where we discovered the issue. The behavior handles copying WKT from the input field under the map into the drawing layer.

(function () {
  farmOS.map.behaviors.wkt_refresh = {
    attach: function (instance) {

      // Get the wkt input element.
      var wkt = document.getElementById('edit-mymap-value');

      // Run a handleInput() callback when input changes.
      wkt.oninput = handleInput;
      function handleInput(e) {
        if (wkt.value) {

          // Clear features from the current edit layer's source.
          instance.edit.layer.getSource().clear();

          // Add a new temporary invisible WKT layer.
          var layer = instance.addLayer('wkt', {
            title: 'WKT',
            wkt: wkt.value,
            visible: false,
          });

          // Copy features from the WKT layer to the edit layer.
          instance.edit.layer.getSource().addFeatures(layer.getSource().getFeatures());

          // Remove the temporary WKT layer.
          instance.map.removeLayer(layer);

          // Zoom to the edit layer.
          instance.zoomToLayer(instance.edit.layer);
        } else if (wkt.value === '') {

          // Clear features from the current edit layer's source.
          instance.edit.layer.getSource().clear();
        }
      }
    },

    // Make sure this runs after farmOS.map.behaviors.wkt.
    weight: 101
  };
}());

(Note this currently assumes a map named mymap for the ID matching in var wkt = document.getElementById('edit-mymap-value');)

farmOS / farmOS-map

Layer switcher not necessarily updated when layers are removed from the map #174