search

farmOS / farmOS-map

farmOS-map is an OpenLayers wrapper library designed for agricultural mapping needs. It can be used in any project that has similar requirements.
https://farmOS.github.io/farmOS-map
MIT License
35 stars 21 forks source link

OL v7 #178

Open paul121 opened 1 year ago

paul121 commented 1 year ago

Tracking for bumping the OL dependency to v7: https://github.com/openlayers/openlayers/releases/tag/v7.0.0

I noticed a couple breaking changes that may effect us:

The forEachLayerAtPixel method has been removed from the Map class.

I know we use this downstream in farmOS, likely in farmOS-map too?

Deprecated options have been removed from the Overlay component.

Might not directly effect us but should check on the ol-popup library which uses an overlay.

paul121 commented 1 year ago

I only see one usage of the map.forEachLayerAtPixel method in farmOS-map core: https://github.com/farmOS/farmOS-map/blob/e90a9f8f3f36cb027a5ccdcec65b9a95c22b935a/examples/simple-html-consumer/static/index.html#L42

We use it much more in farmOS core for the "popup" behavior.

mstenta commented 1 year ago

@paul121 We don't use forEachLayerAtPixel() in either farmOS core or farmOS-map core, we use forEachFeatureAtPixel(), which hasn't been deprecated.

forEachFeatureAtPixel() is still part of OL 7.1.0: https://openlayers.org/en/latest/apidoc/module-ol_Map-Map.html#forEachFeatureAtPixel

paul121 commented 1 year ago

Oh my, good catch thanks @mstenta !!