search

farmOS / farmOS-map

farmOS-map is an OpenLayers wrapper library designed for agricultural mapping needs. It can be used in any project that has similar requirements.
https://farmOS.github.io/farmOS-map
MIT License
35 stars 21 forks source link

Map Search Bar no longer generating results #197

Closed gbathree closed 9 months ago

gbathree commented 9 months ago

Describe the bug Search bar in farmOS Map is no longer working. Tested in coffeeshop.farmos.net and another instance (both managed by Farmier). When you attempt to search it reports "Error! No Internet Connection?". I think this is an everywhere issue and should be quickly repeatable. It appears maybe (based on the console log, see below) that this may be a change in CORS policies for the API which would normally return the search results (?).

Expected behavior Should search and find addresses.

Screenshots

image

This was tested in firefox (ubuntu) and probably chrome (windows), but I think this isn't a browser or OS issue.

Additional context Add any other context about the problem here.

paul121 commented 9 months ago

I believe this is the issue: https://github.com/osm-search/Nominatim/issues/3134

The public Nominatim Geocoding API server recently updated/was completely rewritten and introduced this change: https://github.com/osm-search/Nominatim/releases/tag/v4.3.0

Our ol-geocoding dependency needs to be updated for the currect URL path.

mstenta commented 9 months ago

Good catch @gbathree and @paul121! It looks like this has been fixed in ol-geocoder: https://github.com/Dominique92/ol-geocoder/pull/268

We may just need to update our NPM packages and publish a new release.

mstenta commented 9 months ago

Fixed by #198.