farmOS / farmOS-map

farmOS-map is an OpenLayers wrapper library designed for agricultural mapping needs. It can be used in any project that has similar requirements.
https://farmOS.github.io/farmOS-map
MIT License
39 stars 22 forks source link

Update ol-geocoder to ^4.3 to fix search results #197 #198

Closed paul121 closed 1 year ago

paul121 commented 1 year ago

Updating ol-geocoder solves the issue and geocoding search works again. There are a couple changes that come with this:

  1. Search results are no longer autocompleted as you type because this was in violation of Nominatim TOS: https://github.com/Dominique92/ol-geocoder/issues/255#issuecomment-1200202288
  2. You must press "Enter" or click the new "return" icon to execute the search.

All other existing functionality continues to work the same: click on a result, and map zooms to that location.

Also want to note that the ol-geocoder library has transition maintainers in the past month and many of these changes have been implemented by the new maintainer. Here is the old repo link that redirects to the new: https://github.com/jonataswalker/ol-geocoder

ol-geocoder-updated