search

farmOS / farmOS.js

A JavaScript library for working with farmOS data structures and interacting with farmOS servers.
MIT License
15 stars 13 forks source link

Decide whether to keep the `revokeTokens` method. #45

Closed jgaehring closed 2 years ago

jgaehring commented 2 years ago

As I mentioned in farmOS/farmOS-client#471:

@paul121 and I discussed the revokeTokens() method in farmOS.js and he pointed out that we don't currently have the /oauth/revoke route on farmOS 2.x yet. Honestly, I don't think we need it, but we can reevaluate it later. There's a whole long discussion in farmOS/farmOS-client#350 that gets into that a little bit, if anyone's bored and cares to dig.

It would be good to discuss this with @mstenta, if even briefly, before farmOS.js 2.0.0-beta.1, but it's probably not a high priority and can maybe even be flagged as wont-fix if we decide we don't need it.

jgaehring commented 2 years ago

I'm going to remove this method for now, since it doesn't make sense including a non-working method in the beta release. We can always come back to this and revert that change if we wish.