mstenta
commented
3 years ago Tests take a really long time
Agreed - and part of this may be due to the fact that XDebug is installed in the dev image, which is also used for running tests currently. We need to change this. It was just a result of the way I set up the Docker containers and testing instructions originally, and now that our tests are growing it's becoming a problem. That said, I'm not exactly sure how much of an impact it's having, and/or if there are other optimization options.
Everything else you describe is outside the scope of farmOS/Drupal I think, however. We are basically just running phpunit in the recommended way. But I'd certainly love to see some improvements! All of the points you make are valid! This might need to be explored upstream.
Here is where the PHPUnit configuration is set up in our Dockerfile currently: https://github.com/farmOS/farmOS/blob/2ce6c8eac09540ba683a910da37285e5d7e6d3b4/docker/dev/Dockerfile#L56
You may have noticed, but we also have a GitHub Action for building the Docker images from scratch and running the tests: https://github.com/farmOS/farmOS/blob/2.x/.github/workflows/run-tests.yml
This seems to take ~20 minutes on average to run right now. That includes building the images. Tests themselves run in ~15 minutes on GitHub's servers: https://github.com/farmOS/farmOS/actions?query=workflow%3A%22Run+2.x+PHPUnit+tests%22
symbioquine
paul121
I started to play around with the tests for farmOS 2.x with some successes. The tests which hit the database seem to be passing locally, however those which are based on web requests aren't. I'm sure there's something about my configuration which is breaking them, but I'm less concerned about that than the experience of working with the tests.
I may have been spoiled by Java, Python, and even Javascript test frameworks which tend to produce concise, informative stack traces and assertion failures.
Some frustrations here;
<Ctrl>-closes any failure output which might have been later printed for already run test cases - the process just endsI'm hoping there's some magic bullet or tricks that makes phpunit and the Drupal test scaffolding more sane to work with - hopefully without depending on a proprietary IDE - but at worst I guess this issue can just capture the frustration I'm experiencing :)
Examples console output;