App doesn't recognize when it has been logged out

[mstenta]

This is an issue with https://farmOS.app - I'm not sure if it's also an issue with the native apps.

Steps to reproduce:

1. Log into a farmOS instance directly in your browser (eg: https://test.farmOS.net)
2. Log into farmOS.app using the same credentials in a new tab.
3. Log out of farmOS in the first tab.
4. Attempt to sync in farmOS.app - nothing happens - console errors.

[jgaehring]

Hmm, interesting. Yea, I don't know how we're going to reconcile the fact that we're using the same cookies for auth that farmOS uses. Might be tricky, or might involve changing some of how auth is handled by the server.

[mstenta]

Yea that's the cause - and that probably won't happen often.

But I think regardless of that, we may also have the same issue when a session expires? Or are we handling that case already? It seems like it would be the same thing.

[jgaehring]

Attempt to sync in farmOS.app - nothing happens - console errors.

Just console errors? Our error handler isn't picking it up then? At the very least I would hope it would reroute you to the login page.

[mstenta]

Just console errors? Our error handler isn't picking it up then? At the very least I would hope it would reroute you to the login page.

Tested this, and the error handler is picking it up and displaying "Unable to sync because the network is currently unavailable. Please try syncing again later."

However it is not redirecting to the login screen. Presumably because the app thinks it is already logged in?

There is not way to get to the login screen when the app thinks it is already logged in. All you can do is logout and then login again. And logging out destroys unsynced logs, right? :-/

I think we definitely need to add logic that handles this gracefully. The app needs to detect when either a cookie is no longer available, or the session has expired (same mechanism?) and ideally it would automatically try to re-authenticate using stored credentials.

[mstenta]

Another thing to note (with regard to #222): if you are not in the "My Logs" screen, you do not see the error message "Unable to sync because the network is currently unavailable. Please try syncing again later."

Is that only displayed in "My Logs"?

To reproduce: destroy your cookie while still "logged in" to farmOS.app, create a new log, and try to click the "Sync" button when selecting assets/areas... no error.

[mstenta]

FYI: #222 is not a Field Kit issue, it seems, but rather a PostgreSQL compatibility issue. I've moved it to the farmOS queue.

However, everything I said above still stands for this issue.

[jgaehring]

FYI: #222 is not a Field Kit issue

Ah, good to know.

Our auth procedures definitely need overhaul. I guess I was always hoping we'd migrate to OAuth and that would alleviate some of the issues, and in the course of migrating we could address the other issues.

I'm not sure the best way to wade into all the potential issues. Some of this would be related to the error-handling label I've created for tracking those issues. I'd maybe like to create some kind of roadmap for looking further into authentication from the top level down, rather than running around to squash a bunch of bugs individually without really addressing the overall design, which I think may be flawed.

[mstenta]

Our auth procedures definitely need overhaul. I guess I was always hoping we'd migrate to OAuth and that would alleviate some of the issues, and in the course of migrating we could address the other issues.

Agreed - and I think there's some common stuff that would be necessary whether or not we have OAuth (speaking of - might be looking into that soon...)

[jgaehring]

This should be resolved by some of the new bug fixes I just pushed, specifically 8de0278. Now it should reroute you to the login screen.