farmOS / field-kit

A modular, offline-first companion app to farmOS.
https://farmOS.org
GNU General Public License v3.0
60 stars 39 forks source link

Add WKViewOnly flag to config.ios.xml. #334

Closed jgaehring closed 4 years ago

jgaehring commented 4 years ago

This addresses the eventuality that login fails when iOS is rolled back to v0.4.15, and assumes the following was the cause in https://github.com/farmOS/farmOS-client/issues/324#issuecomment-605270324:

  1. Apple has deprecated UIWebView sooner than they announced (see #320), and this has broken essential browser API's such as XMLHttpRequest and Geolocation.

The proposed solution,

we need to push out a release that successfully migrates us to WKWebView to see if that alone fixes it

is implemented here. PR #335 is its counterpart implementation in case the login succeeds.

If we get confirmation that login fails in iOS at v0.4.15, we need to merge this in and deploy it ASAP, as v0.4.17, so we can resolve #320. If login succeeds, we can keep this PR open and use the branch as a basis for the the eventual migration to WKWebView, which will still need to happen, once we have also implemented OAuth (#311). PR #335 will only be a stopgap measure, in the case we need to develop OAuth.