search

farmOS / field-kit

A modular, offline-first companion app to farmOS.
https://farmOS.org
GNU General Public License v3.0
60 stars 39 forks source link

Refactor TasksFilter using new loadLogs action #398

Closed jgaehring closed 2 years ago

jgaehring commented 4 years ago

It seems a bit redundant having an entirely separate filtering implementation now that we have filters built in to how the loadLogs action works.

The main benefit of refactoring would just be the elimination of unnecessary code, but a side effect would be that if the user had a filtered view and hit sync, it would only sync the logs currently in view. I want to say that is a feature, and not a drawback, right?

jgaehring commented 3 years ago

I'm going to get rid of the current date options (eg, "Today", "This Week", "All Time", etc) in this component, at least for the time being. I really like the ergonomics those options affords, but it's always been a little lacking, like when you want to have this week's logs but also the next day's logs. I think this will be remedied by #423, but for the time being, I'm just going to revert to using two FarmDateTimeForm components to set the range explicitly.

jgaehring commented 2 years ago

for the time being, I'm just going to revert to using two FarmDateTimeForm components to set the range explicitly.

I'm think I'm going to forgo the date filters altogether for now, and just wait til I can sort logs by time (#399). We already have caching criteria that should provide some limits. I believe if at that time I add some sensible, hardcoded time limits for the how far back to include logs in the "Done" category, and how far forward for the "Upcoming" category, it will obviate the need for this type of filter.