farmOS / field-kit

A modular, offline-first companion app to farmOS.
https://farmOS.org
GNU General Public License v3.0
60 stars 39 forks source link

Sensors module: cant return to menu bar once in sensor module #415

Open vital-agro opened 3 years ago

vital-agro commented 3 years ago

On iOS 13.6.1 using field kit 0.7.0 I can't return to the menu bar once I enter the sensor module; the three bar icon in the top left is unresponsive. I can access the menu bar from all other modules in FieldKit

@paul121 @jgaehring

jgaehring commented 3 years ago

Hi @vital-agro, we'll need to consult with @paul121 on this one, since he maintains the sensor module code. Likely a breaking change with FK getting bumped to 0.7.0, but I can't say for sure.

paul121 commented 3 years ago

Yep, as @jgaehring suspected it was this commit that had the breaking change: https://github.com/farmOS/farmOS-client/commit/e65d1aec8f838bd69f499a834f4d57654e8ce00a

The fix was changing the farm-menu-bar @click handler to emit toggle-drawer, not toggleDrawer