farmOS / field-kit

A modular, offline-first companion app to farmOS.
https://farmOS.org
GNU General Public License v3.0
60 stars 39 forks source link

Review farmOS Quick Forms #416

Closed jgaehring closed 2 years ago

jgaehring commented 3 years ago

@mstenta and I should take some time to review all the farmOS Quick Forms and think about how they can be converted to Field Modules prior to sprinting on the 0.9.0 milestone. We can use this space to stash ideas and discuss strategy etc.

jgaehring commented 3 years ago

@mstenta, I'm not sure if there are more specific issues you'd like to delve into here, but one thing I'd like to come out of this is a clear set of issues that can be collected under the 2.0.0 milestone.

jgaehring commented 3 years ago

Talked to Greg R yesterday about the possibility of converting the Move Animals Quick Form into a Field Module. I'd also like to think about removing some of the movement functionality from the Tasks module, if that functionality can live in its own module, just so we can refine the Tasks use case a bit more.

I think the Move Animals Quick Form is part of the grazing module, not part of core, but it might be worth evaluating as an early Field Module, just b/c we have so much of the groundwork already laid for such a module, and b/c we don't necessarily need to specialize it for animals (eg, could be generalized a bit to accommodate moving plantings, as well).

mstenta commented 3 years ago

Quick notes/considerations:

jgaehring commented 3 years ago

Awesome, all good things to think about!

I may make a note on our shared timeline re: the readiness of movement/location stuff, just so we're aware of that.

So as it stands now, it IS specific to animals/grazing.

Cool, good to know. I guess I'm wondering whether we could make the Field Module a bit more generalized, where the Quick Form was specialized. The more I consider it, though, the more I'm inclined to your suggestion. Probably better to create a dedicated transplanting module, in addition to an animal movement module, rather than one general module. Then for general operations, users can fall back on the Movement tab in Tasks. I feel like that fulfills the promise of what Field Modules were intended to achieve as workflow-driven experiences.

jgaehring commented 3 years ago

@mstenta, not sure if you want to look at this some time this week, or just punt on it til we're done with the farmOS 2.x support. It's obviously not a blocker for 2.x support, but I wonder if it might behoove us to discuss this a little in advance of the Field Module development that will immediately follow the 2.x stuff, so we know what modules to focus on, and who else we might want to involve in the process.

mstenta commented 3 years ago

@mstenta https://github.com/mstenta, not sure if you want to look at this some time this week

I say we wait until right after 2.x support.

it might behoove us to discuss this a little in advance of the Field Module development that will immediately follow the 2.x stuff, so we know what modules to focus on, and who else we might want to involve in the process.

Yes agreed! Let's look at this next.

It will be fun to review the quick forms, including the form Ajax and submit logic we currently have, because I think that's where most of the complexity will be in converting them to field modules. We may end up needing some additional API features on the server-level - we'll see... but in either case it'll be easier to give it deeper thought when we're about to dive into it.

On Sun, Nov 29, 2020 at 6:52 PM Jamie Gaehring notifications@github.com wrote:

@mstenta https://github.com/mstenta, not sure if you want to look at this some time this week, or just punt on it til we're done with the farmOS 2.x support. It's obviously not a blocker for 2.x support, but I wonder if it might behoove us to discuss this a little in advance of the Field Module development that will immediately follow the 2.x stuff, so we know what modules to focus on, and who else we might want to involve in the process.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/farmOS/farmOS-client/issues/416#issuecomment-735477977, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAXJFMPWX4UES2FA6HLOEDSSLNFPANCNFSM4RNHQBDA .

jgaehring commented 3 years ago

Sounds good! Moving this to the next milestone.

jgaehring commented 3 years ago

@mstenta, perhaps we can find a time to look at this issue, either this week or next, as we figure out timeline for the next couple months.