search

farmOS / field-kit

A modular, offline-first companion app to farmOS.
https://farmOS.org
GNU General Public License v3.0
59 stars 38 forks source link

Fix state/props in all Tasks components #455

Closed jgaehring closed 2 years ago

jgaehring commented 2 years ago

Once I've finished #454, I need to comb through the all the templates and scripts in these SFC's to fix references to properties on logs, assets, etc that have changed in 2.x. For example, log.done === true needs to be changed to log.status === 'done'.

jgaehring commented 2 years ago

Remember to fix state and props in all corresponding menu bars, as well.

jgaehring commented 2 years ago

I believe where TasksEdit.vue is concerned, I'm going to punt on several major features for the alpha release, which are a lot more involved than simple changing a few property names and values:

Right now, I really just want to get Field Kit Core's basic functionality down pat, so I know entities with basic attributes are being stored and synced properly. Details of the Tasks module itself, while vital for the beta release, are a little out of scope for the original goals I had for the alpha, which was really to make sure core and farmOS.js were working as expected.

Perhaps there's a more elegant way, but I'm just going to comment out those sections of the template for now, so I can pick up easily when I get to those issues in the beta milestone. I'll open issues for quantities and movements once I'm done with this basic prop/state stuff, just in case I figure out an easier way before then.

jgaehring commented 2 years ago

After I'm done with TasksEdit, I need to go back to TasksAll and fix how assets and areas are mapped to log properties in the .mapIdsToAssets() and .mapTidsToAreas() methods. This logic should really be moved to the tasks computed property.