farmOS / field-kit

A modular, offline-first companion app to farmOS.
https://farmOS.org
GNU General Public License v3.0
62 stars 39 forks source link

Updates to farmOS.js #472

Closed jgaehring closed 2 years ago

jgaehring commented 2 years ago

No huge changes here, but the changes to farmOS.js (2.0.0-alpha.4) will change how data is structured, which could have impacts on the database, so I thought it could be worth tagging FK too, just to lower the risk of migration issues in the future. Opening this as a PR will give me a chance to see how things look in the preview deployment, and whether #469 is in fact resolved.

jgaehring commented 2 years ago

I squashed a commit and force-pushed my rebased branch to fix the build error, which fixed the build error, but the original runtime error remains. So I'm going to try it again with some regex this time, as outlined in https://github.com/farmOS/farmOS-client/issues/469#issuecomment-943475485.

jgaehring commented 2 years ago

Ugh, this is definitely encouraging me further to scrap Webpack and migrate to Vite, as I mentioned in https://github.com/farmOS/farmOS-client/issues/420#issuecomment-942933621. The Webpack documentation is really not great, and configuration is already hard enough. Looks like there are nice plugins for Vite that use Workbox: https://vite-plugin-pwa.netlify.app/.

But at least it's finally working! I could still do some more testing by connecting to test.farmos.dev, but I'm satisfied with these results as they pertain to the scope of this PR, namely to integrate the changes from farmOS/farmOS.js#34, so I'm going to merge and tag alpha.2.