search

farmOS / field-kit

A modular, offline-first companion app to farmOS.
https://farmOS.org
GNU General Public License v3.0
59 stars 38 forks source link

fix storybook setup #518

Closed wotnak closed 1 year ago

wotnak commented 1 year ago

I fixed storybook setup for farm-ui package.

Besides configuring storybook, I also made a couple small changes to the components:

When it comes to the storybook setup, I used storybook v7, which is currently in beta - not sure if this is something you would be okay with or if you'd prefer to use the fully released version. I had also run the csf-2-to-3 migration which automatically changed stories format, so they might need to be manually tided up a bit.

I also made one change outside farm-ui package , I removed overflow-y: hidden applied on body in the main field-kit stylesheet, I'm not sure why it was added in the first place, but it blocked the ability to scroll icons story, as well as longer pages/forms added to field-kit by field modules.

Storybook built with all the changes: https://startling-ganache-6ea7c3.netlify.app/

wotnak commented 1 year ago

It looks like story controls are not working. Will work on them tomorrow.

jgaehring commented 1 year ago

I still need to dig deeper, but this looks incredible!!!

If the controls are giving you trouble, let me know and I can take a look. Or any other questions.

I left myself a little comment to make sure I check that the changed type in package.json doesn't effect how it's imported by the field-kit package; pretty sure it won't, and maybe you've already checked, but should be a straight-forward fix even if there is an issue.

jgaehring commented 1 year ago

Hi, @wotnak, sorry I forgot to come back to this, but were there any other commits you wanted to add? I'll make sure to review this more closely today and will merge it in if all looks good. Thanks again!