Link stops at dollar sign

opk12 commented 1 year ago

The part of a URL after a dollar sign is not part of the auto-generated link, however the dollar is an allowed character in URLs (per stackoverflow) and has real-world usage in Matrix chat message permalinks.

For example:

I want to take note of a message from a Matrix support channel chat.
I copy-paste the message permalink to give context and a factual source to the future myself: https://matrix.to/#/!YDwlnxbKxEYzjQglHL:t2bot.io/$1655165521271BGQWO:t2l.io
The generated link is incomplete: https://matrix.to/#/!YDwlnxbKxEYzjQglHL:t2bot.io the rest is normal text (not a link).

Markdown takes too long to type when I just need to take a quick note.

farmerbb commented 1 year ago

I can't seem to reproduce this, are you on the latest version (3.0.2)?

opk12 commented 1 year ago

I will try it as soon as it is published on F-droid, I just saw your report that they still have 2.*.

samontab commented 1 year ago

I just tested this, and in the current version on F-droid, v3.0.3, the URL is generated correctly from OP text.

opk12 commented 1 year ago

@samontab Thanks for checking. F-droid is still at 2.3.7 due to the build script issue linked above. For curiosity (I'd rather not install from random people) which repo? 3.0.3 doesn't seem to be in the major repos.

samontab commented 1 year ago

Ah, you're right.

I first installed it through F-Droid, but then at some point replaced it with GitHub build to v3.0.3. I thought I was still using the F-Droid build.

farmerbb / Notepad

Link stops at dollar sign #129