search

farminf / pannellum-react

React Component for Pannellum (open source panorama viewer for the web)
MIT License
112 stars 81 forks source link

React 17.x #93

Open fructus0 opened 2 years ago

fructus0 commented 2 years ago

Hey, will there be support for 17.x react? It works on this version, but installation via npm requires --legacy-peer-deps

farminf commented 2 years ago

I try to make that happen 👍🏽

doorbind commented 2 years ago

17.x support would be nice!

kayvaninvemo commented 2 years ago

I made a working repo, if you think this is a good path let me know to create a PR

farminf commented 2 years ago

would be great :)

saidmoya12 commented 2 years ago

Please update 

"peerDependencies": {
    "react": "16.x"
  },

to

"peerDependencies": {
    "react": ">=16.x <=17.x"
  },
kayvaninvemo commented 2 years ago

would be great :)

I created a PR. I tested it on react 17 and 18.

kayvaninvemo commented 2 years ago

Is there any plan for build and publish the new version?