search

farminf / pannellum-react

React Component for Pannellum (open source panorama viewer for the web)
MIT License
112 stars 81 forks source link

Nextjs css import fix #96

Open kayvaninvemo opened 2 years ago

kayvaninvemo commented 2 years ago

In NextJS if the library imports a css, the build fails. So it is better to let the user to import the css. As this is a breaking change, we need to change a major version.

kayvaninvemo commented 2 years ago

image

How to reslove inmy next js app.

We are waiting for the PR to be merged and published. Meanwhile you can check this one https://github.com/kayvaninvemo/pannellum-react/tree/master

MauriceMorrey commented 2 years ago

Any idea when this will be merged?

aman-technyx commented 1 year ago

image How to reslove inmy next js app.

We are waiting for the PR to be merged and published. Meanwhile you can check this one https://github.com/kayvaninvemo/pannellum-react/tree/master

GETTING ERROR windows is undefined

after creating a patch getting so much error

next's 12 react 18

kayvaninvemo commented 1 year ago

This is working on one of our production env. And I could not find the error. With React 17 and Nextjs 12.