search

faroit / python_audio_loading_benchmark

Benchmark popular audio i/o packages
138 stars 10 forks source link

Fix MP4 creation for older ffmpeg versions #2

Closed hagenw closed 5 years ago

hagenw commented 5 years ago

This makes the script work for ffmpeg 2.8.15-0ubuntu0.16.04.1, so basically for Ubuntu 16.04.

I'm not able to test if it will work with newer versions as well. So please test before merging.

faroit commented 5 years ago

thanks. I will look into this. Actually I was using the docker container to also generate the test data, so I wasn't in the need to run older ffmpeg version. I will test if strict affects newer versions..

hagenw commented 5 years ago

~~There seems to be a problem with the current implementation, I have a lot of 0 Bytes MP4 files. Please don't merge the PR yet.~~

Was my fault, the branch is working under Ubuntu 16.04.

hagenw commented 5 years ago

Tested it in docker. Still runs and produces the same results.