Open hagenw opened 5 years ago
yes you are right. the problem is that the commands depend a bit on the OS (e.g. relative paths vs absolute paths for dockers -v
mounts). Also I don't think this repo is important enough for introducing the docker basics ;-)
So I generally mount the whole repo folder...
docker run -v /home/user/repos/python_audio_loading_benchmark
/:/app -it audio-loading-benchmark:latest /bin/bash run.sh
I can add this to the readme, if this makes sense?
Maybe it is also ok to assume from a user to learn docker, but I wasn't able to figure it out in 10 minutes. If it depends for different operation systems, then maybe you add it as an example:
Mount the data directory into the docker container and run `run.sh` inside the
container, e.g.:
```bash
docker run -v /home/user/repos/python_audio_loading_benchmark/:/app \
-it audio_benchmark:latest /bin/bash run.sh
In addition, it might help to be more explicit if the plot command should also be run in docker and how to access the plots/results.
If it depends for different operation systems, then maybe you add it as an example:
looks good, will add this
In addition, it might help to be more explicit if the plot command should also be run in docker and how to access the plots/results.
yes, true. Saving the pickles is also not optimal. I am open to a better pipeline
That's true, but I was not motivated to change that either. It might also not being worth the effort, but lets see.
BTW, I was now able to run the container and reproduce your results.
When you are not used to docker the current documentation is not very explicit on how to mount and run the actual docker container.
E.g. when I run the following:
I get
And if I log into the container with
I'm in a python console and the content of the folder I'm in is: