search

faroit / stempeg

Python I/O for STEM audio files
https://faroit.github.io/stempeg
MIT License
96 stars 13 forks source link

Centralize detection of ffmpeg executables #24

Closed bgamari closed 3 years ago

bgamari commented 4 years ago

In some distributions (e.g. NixOS) ffmpeg is not necessarily in PATH. Unifying detection of the ffmpeg and ffprobe executables makes it easier for packagers to patch the package to accomodate such situations.

faroit commented 4 years ago

@bgamari Thanks for this nice enhancement. The unit tests currently fail for python 2.7. Could you make it compatible? If not, its not a big deal, I will drop 2.7 end of this year anyway...

bgamari commented 4 years ago

Done.

faroit commented 4 years ago

Sorry again for the delay. I now had a deeper look into Python-ffmpeg. Do you think it make sense to make this a dependency and remove the probing code completely?

I don't know of they are good at Cross platform detection of ffmpeg.... I would trust you on this

faroit commented 4 years ago

@bgamari I finished the new ffmpeg frontends in #28 . Your PR is still useful so I would like to merge it after this has been merged into the master.

faroit commented 3 years ago

@bgamari this is now integrated in #28, feel free to add comments over there