The current logic to write the destination config handles the Faros destination (farosai/airbyte-faros-destination) as a special case. We assume the Faros API URL, API key and graph to have been specified via --dst.faros_api_url,--dst.faros_api_key and --dst.graph respectively, and we use these values + "edition": "cloud" as the destination configuration.
This overwrites other values that might have been specified via --dst.edition_configs and is also Faros Cloud edition specific (doesn't support the Community Edition case).
This PR fixes the overwriting issue, while keeping the behavior that the special args (--dst.faros_api_url,--dst.faros_api_key and --dst.graph) are still included in the appropriate place in the configuration, for compatibility with clients are already using it. If we could live with a breaking change, we could get rid of this logic and just have clients specify these args according to their paths in the spec (--dst.edition_configs.faros_api_url,--dst.edition_configs.faros_api_key and --dst.edition_configs.graph).
There is no special logic needed to support Faros Community Edition(or Cloud Edition, except for the sake of keeping compatibility). Clients just need to pass the config values as needed. E.g.,
Description
The current logic to write the destination config handles the Faros destination (
farosai/airbyte-faros-destination
) as a special case. We assume the Faros API URL, API key and graph to have been specified via--dst.faros_api_url
,--dst.faros_api_key
and--dst.graph
respectively, and we use these values +"edition": "cloud"
as the destination configuration.This overwrites other values that might have been specified via
--dst.edition_configs
and is also Faros Cloud edition specific (doesn't support the Community Edition case).This PR fixes the overwriting issue, while keeping the behavior that the special args (
--dst.faros_api_url
,--dst.faros_api_key
and--dst.graph
) are still included in the appropriate place in the configuration, for compatibility with clients are already using it. If we could live with a breaking change, we could get rid of this logic and just have clients specify these args according to their paths in the spec (--dst.edition_configs.faros_api_url
,--dst.edition_configs.faros_api_key
and--dst.edition_configs.graph
).There is no special logic needed to support Faros Community Edition(or Cloud Edition, except for the sake of keeping compatibility). Clients just need to pass the config values as needed. E.g.,
or