Remove faros-destination specific logic

faros-ai / airbyte-local-cli

CLI for running Airbyte sources & destinations locally without Airbyte server

Apache License 2.0

31 stars 3 forks source link

Remove faros-destination specific logic #46

Closed ypc-faros closed 2 years ago

ypc-faros commented 2 years ago

Description

Follow up to https://github.com/faros-ai/airbyte-local-cli/pull/44 We don't need Faros destination specific flags.

Type of change

[ ] Bug fix
[ ] New feature
[X] Breaking change

ypc-faros commented 2 years ago

Why not?

Less code to maintain. We can already do, for example, --dst.edition_configs.faros_api_url without the need for this Faros destination specific logic.

tovbinm commented 2 years ago

Any changes in the readme?

ypc-faros commented 2 years ago

Any changes in the readme?

Done. The gif needs to also be updated... How was it generated?

tovbinm commented 2 years ago

@willmarks knows howto