faros-ai / airbyte-local-cli

CLI for running Airbyte sources & destinations locally without Airbyte server
Apache License 2.0
31 stars 3 forks source link

Redact secrets when debugging #67

Closed willmarks closed 1 year ago

willmarks commented 1 year ago

Description

When using --debug, the secrets provided are output into the logs. They should be redacted. Which fields should be redacted is determined by which properties are airbyte_secret in the source/destination spec

Screenshot 2023-03-17 at 11 28 48 AM

Type of change

willmarks commented 1 year ago

Let me know if y'all think this would be helpful!

willmarks commented 1 year ago

Hmm actually one of my assumptions here is wrong. That assumption being that the source config is flat. let me get this to work with nested configs for the source and the destination.

tovbinm commented 1 year ago

This is awesome!!

willmarks commented 1 year ago

Trying to figure out why the tests work locally but then the config key ordering is different when it is executed in the CI GitHub Action...