search

faros-ai / airbyte-local-cli

CLI for running Airbyte sources & destinations locally without Airbyte server
Apache License 2.0
31 stars 3 forks source link

Explicit connection validation #7

Closed willmarks closed 2 years ago

willmarks commented 2 years ago

Description

Perform connection validation only when flag explicitly set rather than doing it by default

Type of change

willmarks commented 2 years ago

why not check connection every time?

This thought process is based off of the way the ServiceNow source works: The check connection functionality for ServiceNow validates that you have permission to access both the incident table and the user table. However, when a customer only cares about the incident stream, I don't want to require they have the necessary user permissions. Maybe I should switch this to be --no-connection-check or something and validate otherwise?

Also the connection being checked by default is a breaking change if we asked people to update their CLI