faros-ai / airbyte-local-cli

CLI for running Airbyte sources & destinations locally without Airbyte server
Apache License 2.0
31 stars 3 forks source link

FAI-6548 - Support for k8s #77

Closed ogusak closed 1 year ago

ogusak commented 1 year ago

Description

Airbyte-kube-cli for running source-destination connectors on a kubernetes cluster similar to airbyte-local-cli script.

Type of change

ypc-faros commented 1 year ago

Did we consider extending the existing bash script to support k8s and add k8s specific flags? I worry that we'll need to make changes in two places for the common functionality going forward

tovbinm commented 1 year ago

@ypc-faros yes, we should have only one script.

@ogusak I did not realize it's a separate bash file. Let's merge them.

ogusak commented 1 year ago

Merged with the main script - please take a look @ypc-faros @tovbinm

tovbinm commented 1 year ago

@cjwooo @willmarks please review

ogusak commented 1 year ago

@ogusak can you please add a few tests? see how we did this for other commands

Done - please see latest commit

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication