search

farouqdaif1 / space-travelers-hub

3 stars 1 forks source link

Kanban board -review #21

Closed farouqdaif1 closed 2 years ago

farouqdaif1 commented 2 years ago
dasileker commented 2 years ago

Hi @farouqdaif1,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

Check the comments under the review.

Capture web_20-12-2021_15146_gitlab com Capture web_20-12-2021_151340_github com

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

farouqdaif1 commented 2 years ago

Hey, thanks for the review Mr @dasileker but it should be 13, not 17 ??

dasileker commented 2 years ago

Hey, thanks for the review Mr @dasileker but it should be 13, not 17 ??

It's 17th cards, i attached a screen shot

farouqdaif1 commented 2 years ago

Hey, thanks for the review Mr @dasileker but it should be 13, not 17 ??

It's 17th cards, i attached a screen shot

thanks @dasileker I fix the problem

elyor-doniyorov commented 2 years ago

Hi @farouqdaif1 and @Lichapa,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.