farrellm / scad-clj

OpenSCAD DSL in Clojure
Eclipse Public License 1.0
318 stars 51 forks source link

scale attribute for extrude-linear outputs clojure array (without commas) which is a syntax error in openSCAD #50

Open dantheobserver opened 2 years ago

dantheobserver commented 2 years ago

If I do a linear extrude on a model with a scale property as follows extrude-linear {:height body-height :scale [1 0.1] :center false}

what outputs is the following in openscad

linear_extrude (height=62.02, scale=[1 0.1])

this is a syntax error. I think when write-expression encounters clojure arrays it should comma separate them to be save.

dantheobserver commented 2 years ago

seems resolved by https://github.com/farrellm/scad-clj/commit/07eca12b0706e01b2c59edcc384b93f2985b61cc, just needs a release