farridav / django-jazzmin

Jazzy theme for Django
https://django-jazzmin.readthedocs.io
MIT License
1.54k stars 272 forks source link

Update Python & Django supported versions + migrate to ruff #551

Closed samiashi closed 3 months ago

samiashi commented 3 months ago

Update Python supported versions - https://devguide.python.org/versions/

Update Django supported versions - https://www.djangoproject.com/download/#supported-versions

Migrate to ruff - https://github.com/astral-sh/ruff

Miscellaneous

PacificGilly commented 3 months ago

@farridav the 3.11 build is failing https://github.com/farridav/django-jazzmin/actions/runs/8481330654/job/23245748961?pr=551

  coveralls.exception.CoverallsException: Not on TravisCI. You have to provide either repo_token in .coveralls.yml or set the COVERALLS_REPO_TOKEN env var.

I'm not sure why it can't find the COVERALLS_REPO_TOKEN env var as your PRs work without issue. Without seeing the settings, I'm guessing this token is also working with your account maybe? https://github.com/samiashi/django-jazzmin/blob/8a20f52fed70ee8de7a80ae7c2a9d093f3a09830/.github/workflows/build.yml#L18

farridav commented 3 months ago

Yeah it's odd, probably some sort of a permissions issue, I will see if I can make sense of it and get the coveralls token working properly

farridav commented 3 months ago

Right, lets get this moving.. a massive step in the right direction here ..

Next steps will be to make the entire codebase properly typed, start making use of pydantic (or at least data classes) for configuration.

And get some better test coverage :)

farridav commented 3 months ago

Can we get a reabase on this ? Then we can get it merged ...

samiashi commented 3 months ago

Can we get a reabase on this ? Then we can get it merged ...

@farridav Should be rebased with master now