reedjc
commented
5 years ago cmikk fixed another. This is in master. Closing ticket.
Closed reedjc closed 5 years ago
reedjc
commented
5 years ago cmikk fixed another. This is in master. Closing ticket.
I made a branch compiler-warnings to workaround a few compiler warnings. Note I kept the warnings of: ISO C does not support the ''' printf flag in t/test_queue.c since NetBSD has it and Debian stretch manual says "Note that many versions of gcc(1) cannot parse this option and will issue a warning. (SUSv2 did not include %'F, but SUSv3 added it.)" I think by not parsing it still has the output just no locale used of the decimal point. (Note manual says %'F capital F, but our use is lowercase f.) The other compiler warning I didn't handle is: CC src/fstrm_replay.o /home/reed/src/public-github-farsightsec/fstrm/src/fstrm_replay.c:78:2: warning: missing initializer for field 'ar_long_arg' of 'argv_t {aka struct}' [-Wmissing-field-initializers]
{ ARGV_ONE_OF },
^
In file included from /home/reed/src/public-github-farsightsec/fstrm/src/fstrm_replay.c:36:0:
/home/reed/src/public-github-farsightsec/fstrm/libmy/argv.h:81:15: note: 'ar_long_arg' declared here
const char ar_long_arg; / long version of arg, '--delete' /
^}' [-Wmissing-field-initializers]
{ ARGV_LAST },
^
In file included from /home/reed/src/public-github-farsightsec/fstrm/src/fstrm_replay.c:36:0:
/home/reed/src/public-github-farsightsec/fstrm/libmy/argv.h:81:15: note: 'ar_long_arg' declared here
const char ar_long_arg; / long version of arg, '--delete' /
^
~~/home/reed/src/public-github-farsightsec/fstrm/src/fstrm_replay.c:98:2: warning: missing initializer for field 'ar_long_arg' of 'argv_t {aka struct~~CC libmy/argv.o /home/reed/src/public-github-farsightsec/fstrm/libmy/argv.c:2228:18: warning: Potential leak of memory pointed to by 'argv_p' *okay_bp = ARGV_FALSE; ^~~~~~ /home/reed/src/public-github-farsightsec/fstrm/libmy/argv.h:191:21: note: expanded from macro 'ARGV_FALSE'define ARGV_FALSE 0
1 warning generated. CCLD src/fstrm_replay CC src/src_fstrm_capture-fstrm_capture.o /home/reed/src/public-github-farsightsec/fstrm/src/fstrm_capture.c:213:2: warning: missing initializer for field 'ar_long_arg' of 'argv_t {aka struct}' [-Wmissing-field-initializers]
{ ARGV_LAST },
^
In file included from /home/reed/src/public-github-farsightsec/fstrm/src/fstrm_capture.c:49:0:
/home/reed/src/public-github-farsightsec/fstrm/libmy/argv.h:81:15: note: 'ar_long_arg' declared here
const char ar_long_arg; / long version of arg, '--delete' /
^
~~clang also warned about: CC libmy/src_fstrm_capture-argv.o /home/reed/src/public-github-farsightsec/fstrm/libmy/argv.c:2228:18: warning: Potential leak of memory pointed to by 'argv_p' okay_bp = ARGV_FALSE; ^~~~~~ /home/reed/src/public-github-farsightsec/fstrm/libmy/argv.h:191:21: note: expanded from macro 'ARGV_FALSE'define ARGV_FALSE 0
(Note that is in libmy)