farsightsec / nmsg

network message encapsulation library
Apache License 2.0
30 stars 8 forks source link

Extend NMSG Unit Tests #160

Closed kadealicious closed 4 days ago

kadealicious commented 1 month ago

LCOV coverage report shows the following increase in coverage:

This MR contains the following changes:

To generate a coverage report for nmsg-1.2.0 (the current version on the next branch):

make -j
make dist
tar -xvf nmsg-1.2.0.tar.gz
rm nmsg-1.2.0.tar.gz
cd nmsg-1.2.0
./configure --with-coverage
make -j
make check -j
make report-coverage -j
your-browser coverage-html/index.html
shw700 commented 1 month ago

These unit tests (make check) fail for me on my laptop. I just confirmed that the same is NOT the case for either the master or next branches.

kadealicious commented 1 month ago

These unit tests (make check) fail for me on my laptop. I just confirmed that the same is NOT the case for either the master or next branches.

This has been addressed.

shw700 commented 1 month ago

I'm not sure if we should just tag @reedjc in here from the start or wait until it moves past all the devs... I expect he'll be reading through this very closely at some point.