farsightsec / wdns

low-level DNS library
Apache License 2.0
18 stars 5 forks source link

configure checks for pkg-config but not used #18

Open reedjc opened 7 years ago

reedjc commented 7 years ago

While wdns does provide a pkg-config .pc file, it doesn't use any pkg-config files to build. The configure.ac checks for the pkg-config so it can guess a path for installing its wdns.pc file but if doesn't exist it aborts (AC_MSG_ERROR([pkg-config is required!])).

It should not abort. The default standard is fine. My suggestion is to just remove the else there.

Two other related also minor issues:

For most systems it is ${prefix}/lib/pkgconfig.

That second problem is probably copy-and-pasted from libmy. The third problem is a file included from libmy.