farsightsec / wdns

low-level DNS library
Apache License 2.0
18 stars 5 forks source link

unused arguments in tests #19

Closed reedjc closed 4 years ago

reedjc commented 7 years ago

This is trivial and maybe something to do discuss. But -Wall (or -Wunused-parameter) fails for some tests like:

t/test-rdata_to_str.c: In function ‘main’:
t/test-rdata_to_str.c:269:15: error: unused parameter ‘argc’ [-Werror=unused-parameter]
 int main (int argc, char **argv) {
               ^
t/test-rdata_to_str.c:269:28: error: unused parameter ‘argv’ [-Werror=unused-parameter]
 int main (int argc, char **argv) {

Trivial to fix in a few files:

-int main (int argc, char **argv) {
+int main(void) {
reedjc commented 4 years ago

This is fixed. Now in master and 0.10.0