search

farwayer / mobx-decorators

Several helper MobX decorators (setter, observe, save, ...)
157 stars 4 forks source link

peer dependency mobx 4 ? is mobx 5 unsupported? #16

Open jigargosar opened 6 years ago

jigargosar commented 6 years ago
farwayer commented 6 years ago

MobX 5 is not supported yet. Some decorators depend on spy events but spy was removed in v5. Support is possible but I can't provide any ETA.

jigargosar commented 6 years ago

but spy was removed in v5

I am not so sure since I am using spy in v5, let me know. Thanks. https://mobx.js.org/refguide/spy.html

farwayer commented 6 years ago

spy is dev only feature in mobx 5 and has no effect in production build. Decorators can be rewrite to work without using spy but I will have time for this in several weeks only.

On Sat, Aug 18, 2018, 10:51 AM Jigar Gosar notifications@github.com wrote:

but spy was removed in v5

I am not so sure since I am using spy in v5, let me know. Thanks. https://mobx.js.org/refguide/spy.html

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/farwayer/mobx-decorators/issues/16#issuecomment-414039700, or mute the thread https://github.com/notifications/unsubscribe-auth/ACPAvRR7jL30yHm8Wc8k3XmtdpF4OT9Gks5uR8dlgaJpZM4WBFx6 .

jigargosar commented 6 years ago

thanks. there is no rush. I was just curious.

On Mon, 20 Aug 2018 at 15:56 farwayer notifications@github.com wrote:

spy is dev only feature in mobx 5 and has no effect in production build. Decorators can be rewrite to work without using spy but I will have time for this in several weeks only.

On Sat, Aug 18, 2018, 10:51 AM Jigar Gosar notifications@github.com wrote:

but spy was removed in v5

I am not so sure since I am using spy in v5, let me know. Thanks. https://mobx.js.org/refguide/spy.html

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/farwayer/mobx-decorators/issues/16#issuecomment-414039700 , or mute the thread < https://github.com/notifications/unsubscribe-auth/ACPAvRR7jL30yHm8Wc8k3XmtdpF4OT9Gks5uR8dlgaJpZM4WBFx6

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/farwayer/mobx-decorators/issues/16#issuecomment-414270149, or mute the thread https://github.com/notifications/unsubscribe-auth/AABOckdNH5or1GUMqVSyaD344UsNnd1Iks5uSo7xgaJpZM4WBFx6 .

-- @JigarGosar +91 9892 006911