fasheng / elfeed-protocol

Provide extra protocols to make like Fever, NewsBlur, Nextcloud/ownCloud News and Tiny Tiny RSS work with elfeed
GNU General Public License v3.0
100 stars 18 forks source link

fever update to accomodate id generation by freshrss #53

Closed CosmosAtlas closed 2 years ago

CosmosAtlas commented 2 years ago

elfeed-log

NA

error backtrace

NA

Behavior

When currently using a fever feed from FreshRss, update won't show new items.

Root cause

Upon inspection, elfeed-protocol-fever-update basically just fetches 50 new entries based on the last-entry-id. However, FreshRss generates its id by Unix time (some irrelevant discussion here, but covers how the id is implemented).

So it means that, realistically, the update function will never generate new entry ids (given it only generates ids within 50/1000 of a second...)

Suggested fix

I'm not familiar with elisp enough to fix this personally, but below are some highlevel ideas.

Side Note

With unread_item_ids from fever, it would be possible to match with local database, so that read status can be synced the other way around as requested by #38 . Meaning that if a current unread item doesn't exists in fever's new unread_item_ids it can be marked as read.

fasheng commented 2 years ago

Thanks for your report. Here is a workaround for it, if works, just close the issue:

(setq elfeed-protocol-fever-update-unread-only t)
CosmosAtlas commented 2 years ago

Can confirm the work around works for me. Thank you for the quick response!