search

fasheng / elfeed-protocol

Provide extra protocols to make like Fever, NewsBlur, Nextcloud/ownCloud News and Tiny Tiny RSS work with elfeed
GNU General Public License v3.0
97 stars 18 forks source link

Tests: Move fixtures to dedicated JSON files #6

Closed jinnovation closed 6 years ago

jinnovation commented 6 years ago

Moving the fixtures to separate files lets us not only shorten the test files themselves, but also take advantage of, for instance, JSON-specific formatting and display -- both of which contribute to increased flexibility and comprehension.

fasheng commented 6 years ago

Thanks, I should do the work at first. Now you help me finish it :)

BTW: Your git message style is a little different with me, but that's not a problem~

jinnovation commented 6 years ago

Your git message style is a little different with me, but that's not a problem~

Feel free to let me know if there's a style that you'd like to stick with; I'll do my best to accommodate. :+1:

fasheng commented 6 years ago

A minor problem, I run make test failed in the project root dir just now, so updated the test code to get the relative fixtures path in runtime through the variable load-file-name.

About the git style, it's easy, I follow the following rules:

  1. Run git rebase to merge multiple comments to one if necessary when contributing code to others
  2. The category or tag name in git message header should be lowercase, and personally I prefer to use the singular form
  3. The short description message shoud start with a uppercase verb word

So, for example, the comments in this PR coulde merge to one like this ;)

test: Move fixtures to files