Closed jinnovation closed 6 years ago
Thanks, I should do the work at first. Now you help me finish it :)
BTW: Your git message style is a little different with me, but that's not a problem~
Your git message style is a little different with me, but that's not a problem~
Feel free to let me know if there's a style that you'd like to stick with; I'll do my best to accommodate. :+1:
A minor problem, I run make test
failed in the project root dir just now, so updated the test code to get the relative fixtures path in runtime through the variable load-file-name
.
About the git style, it's easy, I follow the following rules:
git rebase
to merge multiple comments to one if necessary when contributing code to othersSo, for example, the comments in this PR coulde merge to one like this ;)
test: Move fixtures to files
Moving the fixtures to separate files lets us not only shorten the test files themselves, but also take advantage of, for instance, JSON-specific formatting and display -- both of which contribute to increased flexibility and comprehension.